New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): add emergency contacts database functions #1081

Open

almostinf wants to merge 18 commits into master from feat/add-emergency-contacts-database-functions

Member

almostinf commented Sep 10, 2024 •

edited

Loading

Add emergency contacts database functions

Added database functions for emergency contacts - these are the contacts to which notifications will go to users in case of emergency types of problems in Moira

almostinf added 11 commits

September 3, 2024 11:15


          add emergency contact api and databse functions

30674ac


          add tests to emergency contacts controller

66417eb


          add tests for controller and database

1e16461


          add handler tests

0ee3801


          fix godoc

9a66164


          merge with master

a2a1456


          add validation on emergency type and emergencyTypeFilter

b3c7ade


          fix linter and api tests

25d469b


          fix godoc in database reply

dd37d7c


          add godoc

3b61fc6


          remove new changes in api

56b489d

almostinf marked this pull request as ready for review

September 10, 2024 11:07

almostinf requested a review from a team as a code owner

September 10, 2024 11:08

AleksandrMatsko previously approved these changes

View reviewed changes

kissken reviewed

View reviewed changes

database/redis/contact.go Show resolved Hide resolved

kissken reviewed

View reviewed changes

database/redis/contact.go Show resolved Hide resolved

kissken reviewed

View reviewed changes

datatypes.go Outdated Show resolved Hide resolved

kissken reviewed

View reviewed changes

database/redis/reply/emergency_contact.go Outdated Show resolved Hide resolved

kissken reviewed

View reviewed changes

database/redis/reply/emergency_contact.go Outdated Show resolved Hide resolved

kissken reviewed

View reviewed changes

datatypes.go Outdated Show resolved Hide resolved

Tetrergeru reviewed

View reviewed changes

database/redis/contact.go Outdated Show resolved Hide resolved

Tetrergeru reviewed

View reviewed changes

database/redis/contact.go Outdated Show resolved Hide resolved

Tetrergeru reviewed

View reviewed changes

database/redis/emergency_contact.go Outdated Show resolved Hide resolved

Tetrergeru reviewed

View reviewed changes

database/redis/emergency_contact.go Outdated Show resolved Hide resolved


          add heartbeat type and rename somrename some database functions

cca0fbc

almostinf dismissed AleksandrMatsko’s stale review via

cca0fbc

September 23, 2024 16:25


          fix emergency contacts tests

affe21b

almostinf requested review from kissken, AleksandrMatsko and Tetrergeru

September 23, 2024 21:44

almostinf added 2 commits

October 1, 2024 11:49


          add datatypes module and fix some naming

b6ca9d2


          add datatypes module and fix some naming

a644573

AleksandrMatsko requested changes

View reviewed changes

datatypes/emergency_contact.go Outdated Show resolved Hide resolved

datatypes/emergency_contact.go Outdated Show resolved Hide resolved

kissken previously approved these changes

View reviewed changes

kissken self-requested a review

October 4, 2024 11:54

almostinf added 2 commits

November 1, 2024 10:39


          Merge branch 'master' into feat/add-emergency-contacts-database-funct…

0ae4665

…ions


          remove unnecessary destroying emergency contact when remove contact a…

c8bf54e

…nd little refactor

almostinf dismissed kissken’s stale review via

c8bf54e

November 1, 2024 07:58

almostinf requested a review from AleksandrMatsko

November 1, 2024 08:06

Tetrergeru previously approved these changes

View reviewed changes

kissken previously approved these changes

View reviewed changes

AleksandrMatsko previously approved these changes

View reviewed changes


          add new heartbeat types

f9fa73a

almostinf dismissed stale reviews from AleksandrMatsko, kissken, and Tetrergeru via

f9fa73a

November 5, 2024 13:37

almostinf requested review from kissken, Tetrergeru and AleksandrMatsko

November 5, 2024 15:51

AleksandrMatsko approved these changes

View reviewed changes

Tetrergeru approved these changes

View reviewed changes

Tetrergeru approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet